stream_test.go
641 lines1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
package assistant_test
import (
"errors"
"io"
"strings"
"testing"
"congo.gg/pkg/assistant"
)
// sseReader wraps a string reader with a no-op Close method for use as io.ReadCloser.
type sseReader struct {
io.Reader
}
func (sseReader) Close() error { return nil }
// newSSEReader creates an io.ReadCloser from raw SSE text.
func newSSEReader(data string) io.ReadCloser {
return sseReader{strings.NewReader(data)}
}
// simpleContentParser is a parseEvent function that treats data as literal content text.
func simpleContentParser(data string) (*assistant.StreamEvent, error) {
if strings.HasPrefix(data, `{"type":"content"`) {
// Extract text value: {"type":"content","text":"..."}
start := strings.Index(data, `"text":"`) + 8
end := strings.LastIndex(data, `"`)
if start > 8 && end > start {
return &assistant.StreamEvent{
Type: assistant.EventContentDelta,
Content: data[start:end],
}, nil
}
}
if strings.HasPrefix(data, `{"type":"tool_start"`) {
id := extractJSONField(data, "id")
name := extractJSONField(data, "name")
return &assistant.StreamEvent{
Type: assistant.EventToolCallStart,
ToolCall: &assistant.ToolCall{
ID: id,
Name: name,
},
}, nil
}
if strings.HasPrefix(data, `{"type":"tool_delta"`) {
args := extractJSONField(data, "arguments")
return &assistant.StreamEvent{
Type: assistant.EventToolCallDelta,
ToolCall: &assistant.ToolCall{
Arguments: args,
},
}, nil
}
if strings.HasPrefix(data, `{"type":"error"`) {
msg := extractJSONField(data, "message")
return &assistant.StreamEvent{
Type: assistant.EventError,
Error: errors.New(msg),
}, nil
}
if strings.HasPrefix(data, `{"type":"done"`) {
return &assistant.StreamEvent{
Type: assistant.EventDone,
}, nil
}
return nil, errors.New("unknown event type")
}
// extractJSONField extracts a simple string field from a JSON-like string.
func extractJSONField(data, field string) string {
key := `"` + field + `":"`
start := strings.Index(data, key)
if start < 0 {
return ""
}
start += len(key)
end := strings.Index(data[start:], `"`)
if end < 0 {
return ""
}
return data[start : start+end]
}
func TestStreamReaderContentDelta(t *testing.T) {
sse := "data: {\"type\":\"content\",\"text\":\"Hello\"}\n\n" +
"data: {\"type\":\"content\",\"text\":\" World\"}\n\n" +
"data: [DONE]\n\n"
reader := assistant.NewStreamReader(newSSEReader(sse), simpleContentParser)
defer reader.Close()
// First event: "Hello"
event := reader.Next()
if event == nil {
t.Fatal("expected event, got nil")
}
if event.Type != assistant.EventContentDelta {
t.Errorf("Type = %d, want EventContentDelta (%d)", event.Type, assistant.EventContentDelta)
}
if event.Content != "Hello" {
t.Errorf("Content = %q, want %q", event.Content, "Hello")
}
// Second event: " World"
event = reader.Next()
if event == nil {
t.Fatal("expected event, got nil")
}
if event.Type != assistant.EventContentDelta {
t.Errorf("Type = %d, want EventContentDelta", event.Type)
}
if event.Content != " World" {
t.Errorf("Content = %q, want %q", event.Content, " World")
}
// Done event
event = reader.Next()
if event == nil {
t.Fatal("expected done event, got nil")
}
if event.Type != assistant.EventDone {
t.Errorf("Type = %d, want EventDone (%d)", event.Type, assistant.EventDone)
}
// Accumulated content
if reader.Content() != "Hello World" {
t.Errorf("Content() = %q, want %q", reader.Content(), "Hello World")
}
}
func TestStreamReaderToolCallStartAndDelta(t *testing.T) {
sse := "data: {\"type\":\"tool_start\",\"id\":\"call_1\",\"name\":\"search\"}\n\n" +
"data: {\"type\":\"tool_delta\",\"arguments\":\"{\\\"q\\\"\"}\n\n" +
"data: {\"type\":\"tool_delta\",\"arguments\":\":\\\"test\\\"}\"}\n\n" +
"data: [DONE]\n\n"
// Custom parser that handles tool_delta with escaped JSON
parser := func(data string) (*assistant.StreamEvent, error) {
if strings.HasPrefix(data, `{"type":"tool_start"`) {
id := extractJSONField(data, "id")
name := extractJSONField(data, "name")
return &assistant.StreamEvent{
Type: assistant.EventToolCallStart,
ToolCall: &assistant.ToolCall{
ID: id,
Name: name,
},
}, nil
}
if strings.HasPrefix(data, `{"type":"tool_delta"`) {
// Extract arguments - handle escaped quotes
key := `"arguments":"`
start := strings.Index(data, key)
if start < 0 {
return nil, errors.New("no arguments")
}
start += len(key)
// Find closing quote (not escaped)
end := start
for end < len(data) {
if data[end] == '\\' {
end += 2
continue
}
if data[end] == '"' {
break
}
end++
}
args := data[start:end]
args = strings.ReplaceAll(args, `\"`, `"`)
args = strings.ReplaceAll(args, `\\`, `\`)
return &assistant.StreamEvent{
Type: assistant.EventToolCallDelta,
ToolCall: &assistant.ToolCall{
Arguments: args,
},
}, nil
}
return nil, errors.New("unknown")
}
reader := assistant.NewStreamReader(newSSEReader(sse), parser)
defer reader.Close()
// Tool call start
event := reader.Next()
if event == nil {
t.Fatal("expected tool_start event, got nil")
}
if event.Type != assistant.EventToolCallStart {
t.Errorf("Type = %d, want EventToolCallStart (%d)", event.Type, assistant.EventToolCallStart)
}
if event.ToolCall.ID != "call_1" {
t.Errorf("ToolCall.ID = %q, want %q", event.ToolCall.ID, "call_1")
}
if event.ToolCall.Name != "search" {
t.Errorf("ToolCall.Name = %q, want %q", event.ToolCall.Name, "search")
}
// Tool call delta 1
event = reader.Next()
if event == nil {
t.Fatal("expected tool_delta event, got nil")
}
if event.Type != assistant.EventToolCallDelta {
t.Errorf("Type = %d, want EventToolCallDelta (%d)", event.Type, assistant.EventToolCallDelta)
}
// Tool call delta 2
event = reader.Next()
if event == nil {
t.Fatal("expected second tool_delta event, got nil")
}
if event.Type != assistant.EventToolCallDelta {
t.Errorf("Type = %d, want EventToolCallDelta", event.Type)
}
// Done
event = reader.Next()
if event == nil {
t.Fatal("expected done event, got nil")
}
if event.Type != assistant.EventDone {
t.Errorf("Type = %d, want EventDone", event.Type)
}
// Check accumulated tool calls
toolCalls := reader.ToolCalls()
if len(toolCalls) != 1 {
t.Fatalf("ToolCalls length = %d, want 1", len(toolCalls))
}
if toolCalls[0].ID != "call_1" {
t.Errorf("ToolCalls[0].ID = %q, want %q", toolCalls[0].ID, "call_1")
}
if toolCalls[0].Name != "search" {
t.Errorf("ToolCalls[0].Name = %q, want %q", toolCalls[0].Name, "search")
}
expectedArgs := `{"q":"test"}`
if toolCalls[0].Arguments != expectedArgs {
t.Errorf("ToolCalls[0].Arguments = %q, want %q", toolCalls[0].Arguments, expectedArgs)
}
}
func TestStreamReaderDoneViaDONEMarker(t *testing.T) {
sse := "data: {\"type\":\"content\",\"text\":\"hi\"}\n\n" +
"data: [DONE]\n\n"
reader := assistant.NewStreamReader(newSSEReader(sse), simpleContentParser)
defer reader.Close()
// Content event
event := reader.Next()
if event == nil || event.Type != assistant.EventContentDelta {
t.Fatal("expected content event")
}
// DONE marker
event = reader.Next()
if event == nil || event.Type != assistant.EventDone {
t.Fatal("expected done event from [DONE] marker")
}
if !reader.Done() {
t.Error("Done() = false after [DONE] marker, want true")
}
// Subsequent calls return nil
event = reader.Next()
if event != nil {
t.Errorf("expected nil after done, got event type %d", event.Type)
}
}
func TestStreamReaderDoneViaEOF(t *testing.T) {
// No [DONE] marker, stream just ends
sse := "data: {\"type\":\"content\",\"text\":\"hi\"}\n\n"
reader := assistant.NewStreamReader(newSSEReader(sse), simpleContentParser)
defer reader.Close()
// Content event
event := reader.Next()
if event == nil || event.Type != assistant.EventContentDelta {
t.Fatal("expected content event")
}
// EOF causes done
event = reader.Next()
if event == nil {
t.Fatal("expected done event on EOF")
}
if event.Type != assistant.EventDone {
t.Errorf("Type = %d, want EventDone (%d)", event.Type, assistant.EventDone)
}
if !reader.Done() {
t.Error("Done() = false after EOF, want true")
}
}
func TestStreamReaderErrorEvent(t *testing.T) {
sse := "data: {\"type\":\"error\",\"message\":\"rate limited\"}\n\n"
reader := assistant.NewStreamReader(newSSEReader(sse), simpleContentParser)
defer reader.Close()
event := reader.Next()
if event == nil {
t.Fatal("expected error event, got nil")
}
if event.Type != assistant.EventError {
t.Errorf("Type = %d, want EventError (%d)", event.Type, assistant.EventError)
}
if event.Error == nil {
t.Fatal("Error is nil")
}
if event.Error.Error() != "rate limited" {
t.Errorf("Error = %q, want %q", event.Error.Error(), "rate limited")
}
// After error event, Err() should return the error
if reader.Err() == nil {
t.Error("Err() = nil after error event, want non-nil")
}
}
func TestStreamReaderReadError(t *testing.T) {
// Use a pipe and close the write end with an error
pr, pw := io.Pipe()
pw.CloseWithError(errors.New("connection reset"))
reader := assistant.NewStreamReader(pr, simpleContentParser)
defer reader.Close()
event := reader.Next()
if event == nil {
t.Fatal("expected error event, got nil")
}
if event.Type != assistant.EventError {
t.Errorf("Type = %d, want EventError (%d)", event.Type, assistant.EventError)
}
if event.Error == nil {
t.Fatal("Error is nil")
}
if reader.Err() == nil {
t.Error("Err() = nil after read error, want non-nil")
}
}
func TestStreamReaderCollect(t *testing.T) {
sse := "data: {\"type\":\"content\",\"text\":\"Hello\"}\n\n" +
"data: {\"type\":\"content\",\"text\":\" there\"}\n\n" +
"data: [DONE]\n\n"
reader := assistant.NewStreamReader(newSSEReader(sse), simpleContentParser)
defer reader.Close()
resp, err := reader.Collect()
if err != nil {
t.Fatalf("Collect returned error: %v", err)
}
if resp.Content != "Hello there" {
t.Errorf("Content = %q, want %q", resp.Content, "Hello there")
}
if resp.FinishReason != "stop" {
t.Errorf("FinishReason = %q, want %q", resp.FinishReason, "stop")
}
if len(resp.ToolCalls) != 0 {
t.Errorf("ToolCalls length = %d, want 0", len(resp.ToolCalls))
}
}
func TestStreamReaderCollectWithToolCalls(t *testing.T) {
sse := "data: {\"type\":\"content\",\"text\":\"Let me search.\"}\n\n" +
"data: {\"type\":\"tool_start\",\"id\":\"call_1\",\"name\":\"search\"}\n\n" +
"data: [DONE]\n\n"
reader := assistant.NewStreamReader(newSSEReader(sse), simpleContentParser)
defer reader.Close()
resp, err := reader.Collect()
if err != nil {
t.Fatalf("Collect returned error: %v", err)
}
if resp.Content != "Let me search." {
t.Errorf("Content = %q, want %q", resp.Content, "Let me search.")
}
if resp.FinishReason != "tool_calls" {
t.Errorf("FinishReason = %q, want %q", resp.FinishReason, "tool_calls")
}
if len(resp.ToolCalls) != 1 {
t.Fatalf("ToolCalls length = %d, want 1", len(resp.ToolCalls))
}
if resp.ToolCalls[0].Name != "search" {
t.Errorf("ToolCalls[0].Name = %q, want %q", resp.ToolCalls[0].Name, "search")
}
}
func TestStreamReaderCollectError(t *testing.T) {
sse := "data: {\"type\":\"content\",\"text\":\"partial\"}\n\n" +
"data: {\"type\":\"error\",\"message\":\"server error\"}\n\n"
reader := assistant.NewStreamReader(newSSEReader(sse), simpleContentParser)
defer reader.Close()
_, err := reader.Collect()
if err == nil {
t.Fatal("Collect should return error")
}
if err.Error() != "server error" {
t.Errorf("error = %q, want %q", err.Error(), "server error")
}
}
func TestStreamReaderClose(t *testing.T) {
sse := "data: {\"type\":\"content\",\"text\":\"hello\"}\n\n" +
"data: {\"type\":\"content\",\"text\":\" world\"}\n\n" +
"data: [DONE]\n\n"
reader := assistant.NewStreamReader(newSSEReader(sse), simpleContentParser)
// Read one event
event := reader.Next()
if event == nil || event.Type != assistant.EventContentDelta {
t.Fatal("expected content event")
}
// Close the reader
err := reader.Close()
if err != nil {
t.Fatalf("Close returned error: %v", err)
}
// After close, Done should be true
if !reader.Done() {
t.Error("Done() = false after Close(), want true")
}
// Next should return nil after close
event = reader.Next()
if event != nil {
t.Errorf("expected nil after Close(), got event type %d", event.Type)
}
}
func TestStreamReaderSkipsComments(t *testing.T) {
sse := ": this is a comment\n\n" +
"data: {\"type\":\"content\",\"text\":\"hello\"}\n\n" +
": another comment\n\n" +
"data: [DONE]\n\n"
reader := assistant.NewStreamReader(newSSEReader(sse), simpleContentParser)
defer reader.Close()
event := reader.Next()
if event == nil {
t.Fatal("expected content event, got nil")
}
if event.Type != assistant.EventContentDelta {
t.Errorf("Type = %d, want EventContentDelta", event.Type)
}
if event.Content != "hello" {
t.Errorf("Content = %q, want %q", event.Content, "hello")
}
event = reader.Next()
if event == nil || event.Type != assistant.EventDone {
t.Fatal("expected done event")
}
}
func TestStreamReaderSkipsEmptyLines(t *testing.T) {
sse := "\n\n\ndata: {\"type\":\"content\",\"text\":\"hi\"}\n\n\n\ndata: [DONE]\n\n"
reader := assistant.NewStreamReader(newSSEReader(sse), simpleContentParser)
defer reader.Close()
event := reader.Next()
if event == nil {
t.Fatal("expected content event, got nil")
}
if event.Content != "hi" {
t.Errorf("Content = %q, want %q", event.Content, "hi")
}
}
func TestStreamReaderContentAccumulation(t *testing.T) {
sse := "data: {\"type\":\"content\",\"text\":\"A\"}\n\n" +
"data: {\"type\":\"content\",\"text\":\"B\"}\n\n" +
"data: {\"type\":\"content\",\"text\":\"C\"}\n\n" +
"data: [DONE]\n\n"
reader := assistant.NewStreamReader(newSSEReader(sse), simpleContentParser)
defer reader.Close()
// Read first event - Content() should have "A"
reader.Next()
if reader.Content() != "A" {
t.Errorf("Content() after 1st event = %q, want %q", reader.Content(), "A")
}
// Read second event - Content() should have "AB"
reader.Next()
if reader.Content() != "AB" {
t.Errorf("Content() after 2nd event = %q, want %q", reader.Content(), "AB")
}
// Read third event - Content() should have "ABC"
reader.Next()
if reader.Content() != "ABC" {
t.Errorf("Content() after 3rd event = %q, want %q", reader.Content(), "ABC")
}
}
func TestStreamReaderToolCallsAccumulation(t *testing.T) {
sse := "data: {\"type\":\"tool_start\",\"id\":\"call_1\",\"name\":\"fn_a\"}\n\n" +
"data: {\"type\":\"tool_start\",\"id\":\"call_2\",\"name\":\"fn_b\"}\n\n" +
"data: [DONE]\n\n"
reader := assistant.NewStreamReader(newSSEReader(sse), simpleContentParser)
defer reader.Close()
reader.Next() // tool_start 1
calls := reader.ToolCalls()
if len(calls) != 1 {
t.Fatalf("ToolCalls after 1st start = %d, want 1", len(calls))
}
reader.Next() // tool_start 2
calls = reader.ToolCalls()
if len(calls) != 2 {
t.Fatalf("ToolCalls after 2nd start = %d, want 2", len(calls))
}
if calls[0].Name != "fn_a" {
t.Errorf("ToolCalls[0].Name = %q, want %q", calls[0].Name, "fn_a")
}
if calls[1].Name != "fn_b" {
t.Errorf("ToolCalls[1].Name = %q, want %q", calls[1].Name, "fn_b")
}
}
func TestStreamReaderDoneAndErrInitialState(t *testing.T) {
sse := "data: {\"type\":\"content\",\"text\":\"hello\"}\n\ndata: [DONE]\n\n"
reader := assistant.NewStreamReader(newSSEReader(sse), simpleContentParser)
defer reader.Close()
// Before reading anything
if reader.Done() {
t.Error("Done() = true before reading, want false")
}
if reader.Err() != nil {
t.Errorf("Err() = %v before reading, want nil", reader.Err())
}
}
func TestStreamReaderToolCallsReturnsCopy(t *testing.T) {
sse := "data: {\"type\":\"tool_start\",\"id\":\"call_1\",\"name\":\"fn\"}\n\n" +
"data: [DONE]\n\n"
reader := assistant.NewStreamReader(newSSEReader(sse), simpleContentParser)
defer reader.Close()
reader.Next()
calls1 := reader.ToolCalls()
calls2 := reader.ToolCalls()
// Modify the first slice and verify the second is unaffected
if len(calls1) != 1 || len(calls2) != 1 {
t.Fatal("expected 1 tool call in each slice")
}
calls1[0].Name = "modified"
if calls2[0].Name == "modified" {
t.Error("ToolCalls() did not return a copy; modifying one slice affected the other")
}
}
func TestStreamReaderEmptyStream(t *testing.T) {
sse := "data: [DONE]\n\n"
reader := assistant.NewStreamReader(newSSEReader(sse), simpleContentParser)
defer reader.Close()
event := reader.Next()
if event == nil || event.Type != assistant.EventDone {
t.Fatal("expected done event from empty stream")
}
if reader.Content() != "" {
t.Errorf("Content() = %q, want empty string", reader.Content())
}
if len(reader.ToolCalls()) != 0 {
t.Errorf("ToolCalls() length = %d, want 0", len(reader.ToolCalls()))
}
}
func TestStreamReaderSkipsUnparseableEvents(t *testing.T) {
sse := "data: {\"type\":\"unknown_garbage\"}\n\n" +
"data: {\"type\":\"content\",\"text\":\"good\"}\n\n" +
"data: [DONE]\n\n"
reader := assistant.NewStreamReader(newSSEReader(sse), simpleContentParser)
defer reader.Close()
// The unknown event should be skipped, first readable event is "good"
event := reader.Next()
if event == nil {
t.Fatal("expected content event, got nil")
}
if event.Type != assistant.EventContentDelta {
t.Errorf("Type = %d, want EventContentDelta", event.Type)
}
if event.Content != "good" {
t.Errorf("Content = %q, want %q", event.Content, "good")
}
}
func TestEventTypeConstants(t *testing.T) {
// Verify event type constants are distinct
types := map[assistant.EventType]string{
assistant.EventContentDelta: "EventContentDelta",
assistant.EventToolCallStart: "EventToolCallStart",
assistant.EventToolCallDelta: "EventToolCallDelta",
assistant.EventDone: "EventDone",
assistant.EventError: "EventError",
}
if len(types) != 5 {
t.Errorf("expected 5 distinct event types, got %d", len(types))
}
}